fix: Fail on the s390x architecture with a not supported msg #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #96 +/- ##
=========================================
+ Coverage 0 78.43% +78.43%
=========================================
Files 0 2 +2
Lines 0 255 +255
=========================================
+ Hits 0 200 +200
- Misses 0 55 +55 ☔ View full report in Codecov by Sentry. |
spetrosi
force-pushed
the
s390x-incompatible
branch
from
c24a4c5 to
3614220
Compare
|
[citest] |
richm
reviewed
Apr 12, 2024
spetrosi
force-pushed
the
s390x-incompatible
branch
3 times, most recently
from
9cf5a98 to
caa9168
Compare
spetrosi
force-pushed
the
s390x-incompatible
branch
from
caa9168 to
37cf730
Compare
|
[citest] |
richm
reviewed
Apr 12, 2024
|
[citest] |
richm
reviewed
Apr 12, 2024
spetrosi
force-pushed
the
s390x-incompatible
branch
from
1d39450 to
60c0351
Compare
|
[citest] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement: Fail on the s390x architecture with a not supported msg
Reason: the bootloader role does not support s390x architecture because s390x uses a different bootloader - not grub2. Currently, the role fails on s390x with grub2-tools rpm not available.
Result: The role fails with a clear error message that s390x is not supported.
Issue Tracker Tickets (Jira or BZ if any): https://issues.redhat.com/browse/SYSROLES-29